Fix deadline inference, test GEDF, and remove chain ID #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
added
enhancement
edwardalee
changed the title
petervdonovan
approved these changes
May 28, 2024
|
@edwardalee: After lf-lang/reactor-c#426 has been merged, I'll update reactor-c with an interactive rebase and clean up the history. |
|
I wasn't able to do a full rebase without going through too much trouble because merges with master had already happened along the way, so I just did a small few fixups... But |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deadline propagation. Previously, a reaction would inherit the deadline of a downstream reaction only if there was a data path through ports to the downstream reaction. This corrects this so that a reaction that is lexically earlier than another reaction in a reactor inherits the deadline of that later reactor.
This PR also adds the test PR 426 of reactor-c that checks for correct behavior of the GEDF scheduler. It also updates reactor-c to include the corrected GEDF scheduler.
This PR also gets rid of the chain_id, which never worked.